Change to ActiveRecord MySQL adapter breaks tests

10Jun08

This patch: http://github.com/rails/rails/commit/a37546517dad9f6d9a7de6e1dba4d960909d71e8
means that test database structure is not created properly (integer columns get recreated as bigints).  If you’re also using Foreign Key Migrations, your test database simply won’t get built.  It’s too bad the Rails core team didn’t more carefully consider the implications of this patch.  Anyway, we can correct the mistake with the following patch:

===================================================================
--- vendor/rails/activerecord/lib/active_record/connection_adapters/mysql_adapter.rb	(revision 62)
+++ vendor/rails/activerecord/lib/active_record/connection_adapters/mysql_adapter.rb	(working copy)
@@ -470,9 +470,9 @@
         case limit
         when 0..3
           "smallint(#{limit})"
-        when 4..8
+        when 4..11
           "int(#{limit})"
-        when 9..20
+        when 12..20
           "bigint(#{limit})"
         else
           'int(11)'

Filed under: rails   |  4 Comments